Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to run docker lint on every PR #62

Merged
merged 8 commits into from
Jan 30, 2024
Merged

Changes to run docker lint on every PR #62

merged 8 commits into from
Jan 30, 2024

Conversation

dannymandel
Copy link
Member

@dannymandel dannymandel commented Jan 26, 2024 •
edited
Loading

As a general rule, we should validate our Docker files before merging them. Hook up https://github.com/projectatomic/dockerfile_lint to the CI process.

@dannymandel dannymandel added the wontfix This will not be worked on label Jan 26, 2024
@dannymandel dannymandel changed the title This is a test broken file to see if CI catches it Changes to run docker lint on every PR Jan 30, 2024
@dannymandel dannymandel removed the wontfix This will not be worked on label Jan 30, 2024
@dannymandel dannymandel merged commit 64f9db5 into develop Jan 30, 2024
1 check passed
@dannymandel dannymandel deleted the test_broken_file branch January 30, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dannymandel